Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing warnings filter changes from package #22

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Removing warnings filter changes from package #22

merged 1 commit into from
Oct 20, 2021

Conversation

further-reading
Copy link
Contributor

The code warnings.simplefilter("default") expands what warnings are shown and can cause warnings and errors which are normally not expected in other packages to show. In addition, depending on the import order this can override changes to the warnings filter made by the user. I think it would be better to remove this from the package to prevent issues caused by users receiving unexpected warnings/errors.

Copy link
Owner

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think you're probably right, we don't want to change the global warnings settings for all applications. Unfortunately that means that the warnings won't be raised by default and users will likely only notice this when running something like pytest. I can just keep it deprecated for longer in that case.

I'm not sure if this warrants an entirely new release? I might wait for other features or bugfixes before cutting a new release.

@adamjstewart adamjstewart merged commit 84fa8bc into adamjstewart:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants