Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect fiscal_day returned for last day of the year #15

Closed
nicmendoza opened this issue Feb 4, 2021 · 1 comment · Fixed by #16
Closed

Incorrect fiscal_day returned for last day of the year #15

nicmendoza opened this issue Feb 4, 2021 · 1 comment · Fixed by #16
Labels
bug

Comments

@nicmendoza
Copy link
Contributor

The fiscal_day code incorrectly calculates the date delta. Examples:

>>> fiscalyear.FiscalDate(2016,9,30).fiscal_day
1
>>> fiscalyear.FiscalDate(2017,9,30).fiscal_day
365
>>> fiscalyear.FiscalDate(2018,9,30).fiscal_day
366
nicmendoza added a commit to nicmendoza/fiscalyear that referenced this issue Feb 4, 2021
@nicmendoza
Fix for adamjstewart#15 using time delta to better account for leap y…
0fbcd84 
…ears
@adamjstewart
Copy link
Owner

I'm going to look at this in detail this weekend and review your PR. We can do a patch release if we need to.

@adamjstewart adamjstewart mentioned this issue Feb 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix handling of fiscal_days for leap years nicmendoza/fiscalyear
2 participants
@nicmendoza @adamjstewart