Support EJSON.clone(arguments).

This enables (eg) Meteor.apply('foo', arguments). Fixes meteor#946.
adamjspooner · Apr 16, 2013 · 583508e · 583508e
1 parent 4982293
commit 583508e
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 5 deletions.
diff --git a/packages/ejson/ejson.js b/packages/ejson/ejson.js
@@ -301,11 +301,9 @@ EJSON.clone = function (v) {
     }
     return ret;
   }
-  if (_.isArray(v)) {
-    ret = v.slice(0);
-    for (var i = 0; i < v.length; i++)
-      ret[i] = EJSON.clone(ret[i]);
-    return ret;
+  // Clone arrays (and turn 'arguments' into an array).
+  if (_.isArray(v) || _.isArguments(v)) {
+    return _.map(v, EJSON.clone);
   }
   // handle general user-defined typed Objects if they have a clone method
   if (typeof v.clone === 'function') {

diff --git a/packages/ejson/ejson_test.js b/packages/ejson/ejson_test.js
@@ -51,3 +51,24 @@ Tinytest.add("ejson - equality and falsiness", function (test) {
   test.isFalse(EJSON.equals(undefined, {foo: "foo"}));
   test.isFalse(EJSON.equals({foo: "foo"}, undefined));
 });
+
+Tinytest.add("ejson - clone", function (test) {
+  var cloneTest = function (x, identical) {
+    var y = EJSON.clone(x);
+    test.isTrue(EJSON.equals(x, y));
+    test.equal(x === y, !!identical);
+  };
+  cloneTest(null, true);
+  cloneTest(undefined, true);
+  cloneTest(42, true);
+  cloneTest("asdf", true);
+  cloneTest([1, 2, 3]);
+  cloneTest([1, "fasdf", {foo: 42}]);
+  cloneTest({x: 42, y: "asdf"});
+
+  var testCloneArgs = function (/*arguments*/) {
+    var clonedArgs = EJSON.clone(arguments);
+    test.equal(clonedArgs, [1, 2, "foo", [4]]);
+  };
+  testCloneArgs(1, 2, "foo", [4]);
+});