Skip to content

Commit d156dd2

Browse files
committed
Merge pull request daimajia#99 from zhouqiangWang/master
fix removeSliderAt(position) function not work daimajia#88 and a NPE
2 parents effc955 + 97e3276 commit d156dd2

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

demo/src/main/java/com/daimajia/slider/demo/MainActivity.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,9 @@ protected void onCreate(Bundle savedInstanceState) {
5454
.setOnSliderClickListener(this);
5555

5656
//add your extra information
57-
textSliderView.getBundle()
58-
.putString("extra",name);
57+
if (textSliderView.getBundle() != null)
58+
textSliderView.getBundle()
59+
.putString("extra",name);
5960

6061
mDemoSlider.addSlider(textSliderView);
6162
}

library/src/main/java/com/daimajia/slider/library/SliderAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public <T extends BaseSliderView> void removeSlider(T slider){
4949
}
5050

5151
public void removeSliderAt(int position){
52-
if(mImageContents.size() < position){
52+
if(mImageContents.size() > position){
5353
mImageContents.remove(position);
5454
notifyDataSetChanged();
5555
}

0 commit comments

Comments
 (0)