Skip to content

Commit 97e3276

Browse files
committed
removeSliderAt(position) function not work daimajia#88 and a NPE
1. fixed removeSliderAt(position) function not work daimajia#88 logic mistake. 2. NullPointerException in MainActivity.java 05-05 04:12:14.960 472-472/? E/AndroidRuntime﹕ FATAL EXCEPTION: main Process: com.daimajia.slider.demo, PID: 472 java.lang.RuntimeException: Unable to start activity ComponentInfo{com.daimajia.slider.demo/com.daimajia.slider.demo.MainActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.os.Bundle.putString(java.lang.String, java.lang.String)' on a null object reference at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2298) .... Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.os.Bundle.putString(java.lang.String, java.lang.String)' on a null object reference at com.daimajia.slider.demo.MainActivity.onCreate(MainActivity.java:57) at android.app.Activity.performCreate(Activity.java:5933) at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1105)
1 parent e836594 commit 97e3276

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

demo/src/main/java/com/daimajia/slider/demo/MainActivity.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,9 @@ protected void onCreate(Bundle savedInstanceState) {
5454
.setOnSliderClickListener(this);
5555

5656
//add your extra information
57-
textSliderView.getBundle()
58-
.putString("extra",name);
57+
if (textSliderView.getBundle() != null)
58+
textSliderView.getBundle()
59+
.putString("extra",name);
5960

6061
mDemoSlider.addSlider(textSliderView);
6162
}

library/src/main/java/com/daimajia/slider/library/SliderAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public <T extends BaseSliderView> void removeSlider(T slider){
4949
}
5050

5151
public void removeSliderAt(int position){
52-
if(mImageContents.size() < position){
52+
if(mImageContents.size() > position){
5353
mImageContents.remove(position);
5454
notifyDataSetChanged();
5555
}

0 commit comments

Comments
 (0)