Support ESLInt Shareable Configs

[nweldev]

PROBLEM : Shareable Configs simply do not work with gulp-eslint when using configuration files. (using 2.0.0)

USE CASE :

In one of my projects, my lint task isn't showing all eslint errors, while eslint-cli was.

I'm using an eslint-config-noelmace npm dependency, and I assume that the problem could be from that.

Here is an example of configuration :

gulp task configuration (config.paths.scripts is ok) :

export let lintGen = (params = false) => {
    let configuration = params || {};
    configuration.fix = true;
    return lazypipe()
        .pipe(eslint, configuration)
        .pipe(eslint.format)
        .pipe(eslint.failAfterError);
};

gulp.task('lint:scripts', 'Lint the application\'s JS files', () => {
    return gulp.src("app/!(libs)/**/*.js")
        .pipe(debug({
            title: 'test'
        }))
        .pipe(lintGen()());
});

.eslintrc

{
    "extends": "noelmace/angular-base"
}

package.json

{ "scripts" : { "lint": "eslint \"app/!(libs)/**/*.js\" || true" } }

For example, when I'm adding a double quote to my code, npm run lint is showing the following error, when gulp lint:scripts isn't :
31:17 error Strings must use singlequote

[imhoffd]

This issue report is sort of all over the place, but accurate. Shareable Configs simply do not work with gulp-eslint when using configuration files. (using 2.0.0)

[imhoffd]

In the meantime I am using gulp-shell like this:

gulp.task('eslint', shell.task('eslint .'));

Works great 👍

[nweldev]

Yes @dwieeb, sorry, I edited the question to correct that ...

Indeed, the shell works great in Unix environments. But right now, I'm trying to minimise the number of OS dependencies (I'm building a dev environment for Windows 7 users) ...

Any idea where is the problem in gulp-eslint, and how we could fix this ?

[nweldev]

I'll look at util.migrateOptions when I got time, I think the problem could be here.

@dwieeb, could you please juste add some infos on "Shareable Configs simply do not work with gulp-eslint when using configuration files. (using 2.0.0)" ? Did you already try something ? Have you some more knowledge about this issue ?

Maybe @adametry could had some infos about the util.migrateOptions, and why it's not working with shareable config (my apologies, I didn't have enough time to really investigate the code ... I'll do so later).

[shinnn]

I added a test to check if gulp-eslint supports extends: '@your/sharable-config' b0c2816, and the test passes. Perhaps this problem was fixed in 505779d.

@noelmace @dwieeb Feel free to comment more if the problem seems to remain unresolved.

[nweldev]

This issue appeared indeed to have been fixed in one of my new projects. Thank you for your help.

[shinnn]

@noelmace No problem. Thanks for the issue report and confirmation.