Skip to content
This repository was archived by the owner on Apr 18, 2023. It is now read-only.

Update Page Model for Rails 5 #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidstump
Copy link

belongs_to is now explicitly required in the Rails 5 beta. In this situation, an optional parent_id is needed to set a root page with no parent.

Not sure if you want to pull in changes for the beta version of Rails 5 - but I figured I would send it your way and let you decide.

Cheers.

belongs_to is now explicitly required in the Rails 5 beta. In this situation, an optional parent_id is needed to set a root page with no parent.
@scytherswings
Copy link

If this PR is updated, what else is necessary for rails 5 support? I see this fork: https://github.com/NarasimhaReddyY/documentation from @narasimhareddy has a few more changes for 5.1 which looks promising. Might you have any time to look at this @adamcooke ?

@fwolfst
Copy link

fwolfst commented Feb 20, 2019

I believe that I got it running by adding the "[5.2]" to the migrations (e.g. ... < ActiveRecord::Migration[5.2]). Didnt do much tests, though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants