Add support for manifest-v3 Content Security Policy #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new function to compute defaults for the manifest file should be able to maintain the old defaults for manifest-v2 exactly as they were, while also allowing manifest-v3 compatible objects. The function will also emit a warning when an unsupported manifest version is encountered, but for the sake of future-proofing, no errors are emitted, and the compiler process is not halted. Signed-off-by: Buckley Ross <buckleyross42@gmail.com> Change-Id: Id5b36209cb842b0c97698319574751c0d72b767e
leodev87
approved these changes
Jan 9, 2022
This was referenced Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #130 for discussion of the underlying issue.
Given that this PR implements new functionality necessary for supporting manifest-v3 without detracting from any existing functionality, I feel it makes sense to include this in version 0.26.
Description
The new function to compute defaults for the manifest file should be
able to maintain the old defaults for manifest-v2 exactly as they were,
while also allowing manifest-v3 compatible CSP objects.
The function will also emit a warning when an unsupported manifest
version is encountered, but for the sake of future-proofing, no errors
are emitted, and the compiler process is not halted.
Checks
yarn run eslint .yarn test