fixes bullet/list issues in AngularJS markdown #2534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edm00se
commented
Oct 30, 2016
| * HTML | ||
| * CSS | ||
| * JavaScript | ||
|
|
There was a problem hiding this comment.
The line break is needed; I've run into trouble forgetting it before.
edm00se
commented
Oct 30, 2016
| **lowercase: Format a string to lower case. | ||
| **orderBy: Orders an array by an expression. | ||
| **uppercase: Format a string to upper case. | ||
| - **currency**: Format a number to a currency format. |
There was a problem hiding this comment.
Bolding text requires completion. I converted this to a list, as it looked to be one.
edm00se
commented
Oct 30, 2016
| * http://www.w3schools.com/angular/angular_ref_directives.asp | ||
| * http://www.w3schools.com/angular/default.asp | ||
| * https://teamtreehouse.com/library/angular-basics/ | ||
| - http://www.w3schools.com/angular/angular_ref_directives.asp |
There was a problem hiding this comment.
More list conversion.
vendethiel
reviewed
Oct 30, 2016
| * CSS | ||
| * JavaScript | ||
|
|
||
| HTML |
There was a problem hiding this comment.
why is this item not dash-prefixed?
There was a problem hiding this comment.
Uh... that's strange. I thought that was the first thing I did, as it's what I first noticed. One minute, I'll have it corrected.
There looked to be some confused markdown usage; this has been corrected.
edm00se
commented
Oct 31, 2016
| * CSS | ||
| * JavaScript | ||
|
|
||
| - HTML |
There was a problem hiding this comment.
@vendethiel the missing dash prefix is now in place. :-|
|
Thank you for triple and quadruple checking |
23Pstars
pushed a commit
to 23Pstars/learnxinyminutes-docs
that referenced
this pull request
Feb 11, 2017
There looked to be some confused markdown usage; this has been corrected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content changes are aimed at intermediate to experienced programmers (this is a poor format for explaining fundamental programming concepts)YAML Frontmatter formatted according to CONTRIBUTING.mdSeriously, look at it now. Watch for quotes and double-check field names.The last three of the above "tasks" don't seem to apply, this is a documentation change, specifically to an existing entry.
There looked to be some confused markdown usage; this has been corrected. For instance, in the first paragraph of the "What You Should Already Know", the list looks okay in the source markdown file on GitHub, but the rendered html page displayed the list items inline with the asterisk. There were a couple other locations, the section on filters and the footer, with resource links, where bolding an attempt at bolding some key words wasn't completed; the ones in the footer had a list of resources, but weren't actually rendered lists, converted.
Example, before, rendered html on live site:
