[javascript/en] Added for/in loop JavaScript #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For/In loop JavaScript
raphaelbn
changed the title
|
Hi, Thanks for the contribution! IMO, it'd be a good idea to at least mention the fact that this iterates over every property across the entire prototype chain, the existence of |
|
Hi @adambrenecki, Thanks for your attention! I will update with yours suggestion and commit. |
more explanation about for/in java script.
|
Hi @adambrenecki, I've already made the PR with your suggestions. |
| var description = ""; | ||
| var person = {fname:"Paul", lname:"Ken", age:18}; | ||
| for (var x in person) { | ||
| if( person.hasOwnProperty( x ) ) { |
There was a problem hiding this comment.
please fix the code style
Fixing code style
|
Is it ok now, @vendethiel ? |
|
Thanks! |
levibostian
added a commit
that referenced
this pull request
Oct 9, 2015
[javascript/en] Added for/in loop JavaScript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For/In loop JavaScript