Skip to content

Change format of experimental log file #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rombur
Copy link
Member

@Rombur Rombur commented Aug 20, 2025

I propose to change the way the build time log files work. Currently, we subtract the time of the first frame to all the following frames. This is very confusing and I don't know why we do that. @stvdwtt You wrote that code #119 do you remember why we do this?

Would this change break your workflow @stvdwtt @AshGannon ?

@stvdwtt
Copy link
Member

stvdwtt commented Aug 21, 2025

I think the motivation is that we wanted to account for the case where different "cameras" have times that are shifted relative to each other. Subtracting off the first frame time fixes that shift -- but with the weird assumption that these un-synced cameras would emit their first frame at the same real time.

For now I'm fine to just assume that the cameras are synced -- if both data sources come from ROS that should definitely be true. For robustness in the future we might want to add per camera time offsets.

I feel like this has to shift something in the log or the input file -- but looking at https://github.com/adamantine-sim/demonstration-cases/tree/main/nov24_sns_D2_bagged/simulation_template, I'm not sure that anything would change. In that case maybe the observations were accidently shifted by 30 s, skipping the first one?

@Rombur
Copy link
Member Author

Rombur commented Aug 22, 2025

In that case maybe the observations were accidently shifted by 30 s, skipping the first one?

Yes, that's what I think too. I was trying to do data assimilation with the data that @AshGannon gave me and instead of simply shifting everything by 30 s, I used the exact timings from ROS. That gave me unexpected results and that's why I looked at the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants