fix(types): add undefined to types

close #43
adaltas · Jan 10, 2023 · 8efa2e1 · 8efa2e1
1 parent 08923fd
commit 8efa2e1
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 20 deletions.
diff --git a/lib/index.d.ts b/lib/index.d.ts
@@ -4,13 +4,14 @@ declare const httpStatus: httpStatus.HttpStatus;
 
 declare namespace httpStatus {
   interface HttpStatus {
-    readonly [key: number]: string
+    readonly [key: number]: string | undefined;
 
     readonly [key: string]:
-      | string
-      | number
-      | HttpStatusClasses
-      | HttpStatusExtra;
+    | string
+    | number
+    | HttpStatusClasses
+    | HttpStatusExtra
+    | undefined;
 
     readonly 100: string;
     readonly '100_NAME': string;

diff --git a/src/index.d.ts b/src/index.d.ts
@@ -4,13 +4,14 @@ declare const httpStatus: httpStatus.HttpStatus;
 
 declare namespace httpStatus {
   interface HttpStatus {
-    readonly [key: number]: string
+    readonly [key: number]: string | undefined;
 
     readonly [key: string]:
-      | string
-      | number
-      | HttpStatusClasses
-      | HttpStatusExtra;
+    | string
+    | number
+    | HttpStatusClasses
+    | HttpStatusExtra
+    | undefined;
 
     readonly 100: string;
     readonly '100_NAME': string;

diff --git a/test/types.ts b/test/types.ts
@@ -26,7 +26,13 @@ describe('Types', () => {
       const clazz: string = status[`${number}_CLASS`] as string
       clazz.should.eql('1xx')
     })
-
+
+    it('undefined status codes', () => {
+      const undefinedStatusCode = 777
+      const code: string = typeof status[undefinedStatusCode]
+      code.should.eql('undefined')
+    })
+
     it('sub level properties', () => {
       const number: number = status.extra.nginx.NO_RESPONSE
       const code: string = status.extra.nginx[number] as string
@@ -38,41 +44,41 @@ describe('Types', () => {
       const clazz: string = status.extra.nginx[`${number}_CLASS`] as string
       clazz.should.eql('4xx')
     })
-  
+
   })
-  
+
   describe('ES6 exports', () => {
-  
+
     it('HttpStatus', () => {
       const statuses: HttpStatus = status
       statuses.CONTINUE.should.be.a.Number()
     })
-  
+
     it('HttpStatusClasses', () => {
       const classes: HttpStatusClasses = status.classes
       classes.INFORMATIONAL.should.be.a.String()
     })
-  
+
     it('HttpStatusUnofficial', () => {
       const unofficial: HttpStatusUnofficial = status.extra.unofficial
       unofficial.CHECKPOINT.should.be.a.Number()
     })
-  
+
     it('HttpStatusIis', () => {
       const iis: HttpStatusIis = status.extra.iis
       iis.LOGIN_TIME_OUT.should.be.a.Number()
     })
-  
+
     it('HttpStatusNginx', () => {
       const nginx: HttpStatusNginx = status.extra.nginx
       nginx.NO_RESPONSE.should.be.a.Number()
     })
-  
+
     it('HttpStatusCloudfare', () => {
       const cloudflare: HttpStatusCloudfare = status.extra.cloudflare
       cloudflare.UNKNOWN_ERROR.should.be.a.Number()
     })
-  
+
   })
 
 })