Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.12 support #231

Merged
merged 2 commits into from
Jul 27, 2024
Merged

python 3.12 support #231

merged 2 commits into from
Jul 27, 2024

Conversation

FoamyGuy
Copy link
Contributor

The two changes with this PR allow circup to be used under python 3.12 in the following contexts:

  • circup CLI usage by the user
  • pre-commit usage by developers working on circup.

@FoamyGuy FoamyGuy requested a review from a team July 15, 2024 21:29
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but I tried to test it on an Ubuntu 22.04 system by doing pip3 install . after pulling from your branch, to make sure it was backwards compatible, and could not get the install to work properly. It created an UNKNOWN-2.0.4-... package which wasn't really installed anywhere except for a dist-info. The fix for that is supposedly to update setuptools, which I did, which didn't help.

Do you have any way of testing that it's backward compatible, to, say 22.04?


Another thing, which could wait, is the deprecation warnings shown in the CI:
https://github.com/adafruit/circup/actions/runs/9946724203

@FoamyGuy
Copy link
Contributor Author

I have been able to successfully tested it inside of a ubuntu 22.04 docker container.

To test I used these steps:

  • Start a 22.04 ubuntu container with CIRCUITPY drive mounted:
docker run -it -v /media/username/CIRCUITPY/:/media/username/CIRCUITPY:z --entrypoint /bin/bash ubuntu:22.04
  • Inside the container:
apt install git
apt install python3 python3-venv
cd ~
python3 -m venv ~/.venv
source ~/.venv/bin/activate
git clone https://github.com/FoamyGuy/circup.git
cd circup
git checkout support_py312
pip install -e .
circup install adafruit_display_text

It found the device and successfully installed display_text and it's dependencies.

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks for testing on 22.04!

@vkottler
Copy link

Nice patch, just noting I'm using this forked circup branch until merge+publish as well.

@dhalbert dhalbert merged commit 27284f3 into adafruit:main Jul 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants