ports/espressif/supervisor/usb.c: workaround ESP32-S3 USB PHY setup JTAG vs OTG #9973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Also confirmed fixed on Mac Mini that previously showed the problem. Tested with an ESP32-S2 to confirm no regression for non-S3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See hathach/tinyusb#2943 for diagnosis and fix. Thanks @hathach for diagnosis and temporary fix, pending a probable fix in ESP-IDF.
This code is enabled only for ESP32-S3.
Tested on my own system, which manifested the bug before and now does not, with this fix.