Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new board: WIZnet W5100S EVB Pico2 (RP2350) #9791

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Add new board: WIZnet W5100S EVB Pico2 (RP2350) #9791

merged 2 commits into from
Nov 15, 2024

Conversation

anecdata
Copy link
Member

@anecdata anecdata commented Nov 4, 2024 •
edited
Loading

Also add ssl module to WIZnet W5100S EVB Pico (RP2040) board (per #8954 (comment))

@anecdata anecdata mentioned this pull request Nov 5, 2024
Merged
@anecdata
Copy link
Member Author

anecdata commented Nov 5, 2024

Tested adafruit_requests with ssl over Ethernet on:

  • Adafruit CircuitPython 9.2.0-11-g1b8baca968 on 2024-11-04; W5100S-EVB-Pico with rp2040 (1st commit)
  • Adafruit CircuitPython 9.2.0-12-g1bba7b9d14 on 2024-11-05; W5100S-EVB-Pico2 with rp2350a (2nd commit)

@anecdata anecdata marked this pull request as ready for review November 5, 2024 03:42
@anecdata anecdata added network board New board or update to a single board rp2 Both RP2 microcontrollers labels Nov 5, 2024
@anecdata
Copy link
Member Author

anecdata commented Nov 7, 2024

@ViktorWiz Any comments on this? I noticed you did the original PRs for the W5500 and W5100S EVB Picos.

jepler
jepler approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no hw so didn't test but everything looks in order from a quality standpoint. Thank you!

@anecdata
Copy link
Member Author

I think this can be merged. If anything comes up, it should be straightforward to PR.

@jepler jepler merged commit 8cdd96c into adafruit:main Nov 15, 2024
15 checks passed
@anecdata anecdata deleted the wiz branch November 15, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

Assignees
No one assigned
Labels
board New board or update to a single board network rp2 Both RP2 microcontrollers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anecdata @jepler