Skip to content

Disable 9.0.0 displayio warnings #9096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

dhalbert
Copy link
Collaborator

Turn off displayio warnings when using 8.x naming. This was intrusive and confusing for some users. Turn this back on when 8.x bundles are no longer being built.

@dhalbert dhalbert requested a review from tannewt March 26, 2024 20:08
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt
Copy link
Member

tannewt commented Mar 26, 2024

I wonder if this should be 8_10 warnings? 9 has both.

@dhalbert
Copy link
Collaborator Author

dhalbert commented Mar 26, 2024

I wonder if this should be 8_10 warnings? 9 has both.

I meant it was warnings reflecting changes between 8 and 9. This code would be removed entirely in 10. But the name doesn't matter a lot.

@dhalbert
Copy link
Collaborator Author

The silabs port jobs are having trouble fetching the SDK today. I noticed this locally when trying to set up submodules in a new repo clone. So we'll ignore those build errors for now.

@dhalbert dhalbert merged commit 6d1b940 into adafruit:9.0.x Mar 26, 2024
491 of 494 checks passed
@dhalbert dhalbert deleted the 9.0.x-disable-displayio-warnings branch March 27, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants