Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to bug report template #7571

Merged
merged 2 commits into from
Feb 18, 2023

Conversation

tekktrik
Copy link
Member

Minor fixes I noticed in the bug report template while creating one for the libraries.

jepler
jepler previously approved these changes Feb 12, 2023
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, thanks!

Copy link
Collaborator

@microdev1 microdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the python rendering as is. It prettifies the text. What is the issue you encountered?

@tekktrik
Copy link
Member Author

I just saw that the syntax wasn't actually Python and was highlighting "random" parts so I just removed it, but there weren't any actual issues really.

@tekktrik
Copy link
Member Author

I'm definitely not the main consumer of the bug reports, so happy to do whatever is best for those that do.

@microdev1
Copy link
Collaborator

@tekktrik This should be good to merge with the two python changes backed out.

Copy link
Collaborator

@microdev1 microdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @tekktrik.

@microdev1 microdev1 merged commit 9c0165f into adafruit:main Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants