Skip to content

include python executable path in the idf key #6494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

jepler
Copy link

@jepler jepler commented Jun 16, 2022

I noticed that the latest time we needed to switch the idf key was when the environment changed from python 3.10.4 to 3.10.5. I don't know if this is the only cause of needing to change the key, but it seems to be a good idea to make the key include it.

I think this is what's going on because when I replaced a virtualenv's "python" with a dangling symlink (same as would occur when python's version gets bumped), I got a similar error.

May be an alternative to #6493.

I noticed that the latest time we needed to switch the idf key was when
the environment changed from python 3.10.4 to 3.10.5. I don't know if
this is the only cause of needing to change the key, but it seems to be
a good idea to make the key include it.

I think this is what's going on because when I replaced a virtualenv's
"python" with a dangling symlink (same as would occur when python's
version gets bumped), I got a similar error.
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Will merge after CI runs.

@tannewt tannewt mentioned this pull request Jun 16, 2022
@ladyada ladyada merged commit 0aa73da into adafruit:main Jun 17, 2022
@jepler
Copy link
Author

jepler commented Jun 17, 2022

ARGH, I think this was not right. The key that ended up being used was: "Cache not found for input keys: Linux-idf-tools-ce877007ea00fdebf77e4411f91f8667e6ce893604c8d07c9ca35331beb93414--20220404" but instead of "--" it should have been "-/full/path/to/python3.xx.y-".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants