Skip to content

Add Makerfabs ESP32-S2 Parallel TFT board #6119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

deshipu
Copy link

@deshipu deshipu commented Mar 5, 2022

The basic settings and pins are fine, I'm still working on getting the
display to work, I will update it when I get the right init sequence.

More information:
https://www.makerfabs.com/wiki/index.php?title=ESP32-S2_Parallel_TFT_with_Touch(3.5%27%27)

The basic settings and pins are fine, I'm still working on getting the
display to work, I will update it when I get the right init sequence.

More information:
https://www.makerfabs.com/wiki/index.php?title=ESP32-S2_Parallel_TFT_with_Touch(3.5%27%27)
@dhalbert dhalbert marked this pull request as draft March 8, 2022 14:34
@tannewt tannewt added the board New board or update to a single board label Jun 22, 2022
@deshipu deshipu self-assigned this Aug 22, 2022
@tannewt
Copy link
Member

tannewt commented Nov 15, 2022

Any update on this?

Comment on lines +8 to +13
INTERNAL_FLASH_FILESYSTEM = 1
LONGINT_IMPL = MPZ

# The default queue depth of 16 overflows on release builds,
# so increase it to 32.
CFLAGS += -DCFG_TUD_TASK_QUEUE_SZ=32
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
INTERNAL_FLASH_FILESYSTEM = 1
LONGINT_IMPL = MPZ
# The default queue depth of 16 overflows on release builds,
# so increase it to 32.
CFLAGS += -DCFG_TUD_TASK_QUEUE_SZ=32

These have been moved to common mpconfigport.mk and can be removed.

#define DEFAULT_UART_BUS_RX (&pin_GPIO44)
#define DEFAULT_UART_BUS_TX (&pin_GPIO43)

#define BOARD_USER_SAFE_MODE_ACTION translate("pressing boot button at start up.\n")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define BOARD_USER_SAFE_MODE_ACTION translate("pressing boot button at start up.\n")

This message is now the default and can be removed.

@deshipu
Copy link
Author

deshipu commented Nov 18, 2022

Any update on this?

@tannewt No updates. The display doesn't work correctly either in the 8bit or ther 16bit mode, and I couldn't get it working with the current libraries. There is some work to be done with the parallelio before this is working, but I don't currently have the cycles to work on it.

@dhalbert dhalbert linked an issue Nov 28, 2022 that may be closed by this pull request
@dhalbert
Copy link
Collaborator

We discussed closing draft issues that are stuck in the CircuitPython meeting on 2022-11-28 in In the Weeds.

Closing for now. Can be reopened. Tracking in issue #7266, which will remain open.

@dhalbert dhalbert closed this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board New board or update to a single board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Makerfabs ESP32-S2 Parallel TFT board
4 participants