Add a font protocol #5759
Merged
Add a font protocol #5759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
force-pushed
the
font-protocol
branch
from
349d041 to
316c253
Compare
This fixes the lengthy build-time message > setuptools_scm-6.3.2-py3.9.egg/setuptools_scm/integration.py:16: RuntimeWarning: > ERROR: setuptools==44.1.1 is used in combination with setuptools_scm>=6.x > > Your build configuration is incomplete and previously worked by accident! > > > This happens as setuptools is unable to replace itself when a activated build dependency requires a more recent setuptools version (it does not respect "setuptools>X" in setup_requires). > > > setuptools>=31 is required for setup.cfg metadata support > setuptools>=42 is required for pyproject.toml configuration support > > Suggested workarounds if applicable: > - preinstalling build dependencies like setuptools_scm before running setup.py > - installing setuptools_scm using the system package manager to ensure consistency > - migrating from the deprecated setup_requires mechanism to pep517/518 and using a pyproject.toml to declare build dependencies which are reliably pre-installed before running the build tools
dhalbert
approved these changes
Dec 28, 2021
|
Excellent! Let me know if/when it's good to start typing with this then! |
|
I think that when the 7.2.0alpha release is tagged on github, the stubs will be uploaded to pypi as a prerelease. That'll allow use of the new protocol type. |
|
Perfect! Thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tekktrik noticed that there was no convenient way to specify that a function takes "any kind of Font", including the built in one and the ones from the
adafruit_bitmap_fontpackage. By defining this protocol in our stubs, it's hoped thatfontio.FontProtocolcan be used instead of an ad-hocUnion[]of several known font types.