Skip to content

Deprecate Display's constructor arg set_vertical_scroll #5205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2021
Merged

Deprecate Display's constructor arg set_vertical_scroll #5205

merged 1 commit into from
Aug 23, 2021

Conversation

@jepler
Copy link

@jepler jepler commented Aug 23, 2021

Closes: #5189

microdev1
microdev1 approved these changes Aug 23, 2021
View reviewed changes
Copy link
Collaborator

@microdev1 microdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@tannewt
Copy link
Member

tannewt commented Aug 23, 2021

pca10100 is being fixed separately.

@tannewt tannewt merged commit 6d49a9f into adafruit:main Aug 23, 2021
@jepler jepler deleted the deprecate-vertical-scroll branch November 3, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tannewt tannewt tannewt approved these changes

@microdev1 microdev1 microdev1 approved these changes

Assignees

No one assigned

Labels

displayio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove set_vertical_scroll from displayio

3 participants

@jepler @tannewt @microdev1