Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable a BLE workflow #4918

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Enable a BLE workflow #4918

merged 1 commit into from
Jun 24, 2021

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Jun 24, 2021

nRF CircuitPython boards will now provide the file transfer
service defined here: https://github.com/adafruit/Adafruit_CircuitPython_BLE_File_Transfer

USB capable boards will only advertise if previously bonded to a
device or if the reset button is pressed during the fast blue
flashes on start up. When pressed, the board will restart again but
the blue period will not flash.

Boards without USB will always advertise.

When previously bonded, the advertisement is private so that no
other peers can connect. If advertising publicly, the tx power is
lowered to reduce the likelihood of bonding from a distance.

This PR also fixes issues with loading identities of bonded peers
so that our address can now be resolved and we can resolve others'
addresses when scanning.

nRF CircuitPython boards will now provide the file transfer
service defined here: https://github.com/adafruit/Adafruit_CircuitPython_BLE_File_Transfer

USB capable boards will only advertise if previously bonded to a
device or if the reset button is pressed during the fast blue
flashes on start up. When pressed, the board will restart again but
the blue period will not flash.

Boards without USB will always advertise.

When previously bonded, the advertisement is private so that no
other peers can connect. If advertising publicly, the tx power is
lowered to reduce the likelihood of bonding from a distance.

This PR also fixes issues with loading identities of bonded peers
so that our address can now be resolved and we can resolve others'
addresses when scanning.
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I did not test it (I don't have the apps).

I think it would be nice in the long run to factor out the file transfer protocol code in shared/bluetooth.c into its own library (repo?) or at least its own file.

@tannewt
Copy link
Member Author

tannewt commented Jun 24, 2021

Looks good! I did not test it (I don't have the apps).

I think it would be nice in the long run to factor out the file transfer protocol code in shared/bluetooth.c into its own library (repo?) or at least its own file.

I just started on adding BLE serial support and I'm making a bluetooth subfolder similar to the usb one. I don't think it should be a separate repo because its build on top of common_hal APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants