STM32: Cpython compatibility flag 2

[hierophect]

A continuation of #2439, which got merged prematurely. Please do not merge until @jerryneedell has had a chance to review. Should resolve #2433 when finished.

[jerryneedell]

still no joy

Press any key to enter the REPL. Use CTRL-D to reload.
Adafruit CircuitPython 5.0.0-beta.2-91-gb778aee21 on 2020-01-06; Feather STM32F405 Express with STM32F405RG
>>> import minimqtt_demo
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "minimqtt_demo.py", line 94, in <module>
  File "adafruit_minimqtt.py", line 120, in __init__
AttributeError: 'str' object has no attribute 'encode'
>>> string = "test"
>>> dir(string)
['count', 'endswith', 'find', 'format', 'index', 'isalpha', 'isdigit', 'islower', 'isspace', 'isupper', 'join', 'lower', 'lstrip', 'replace', 'rfind', 'rindex', 'rsplit', 'rstrip', 'split', 'startswith', 'strip', 'upper']
>>> 

for comparison -- on grand_central

Press any key to enter the REPL. Use CTRL-D to reload.
Adafruit CircuitPython 5.0.0-beta.2-90-g776c9b011 on 2020-01-04; Adafruit Grand Central M4 Express with samd51p20
>>> string='test'
>>> dir(string)
['__class__', 'center', 'count', 'encode', 'endswith', 'find', 'format', 'index', 'isalpha', 'isdigit', 'islower', 'isspace', 'isupper', 'join', 'lower', 'lstrip', 'partition', 'replace', 'rfind', 'rindex', 'rpartition', 'rsplit', 'rstrip', 'split', 'splitlines', 'startswith', 'strip', 'upper']
>>> 

[hierophect]

This will require further investigation then. I was hoping the build order would put the board settings and overrides last. I'll need to dig deeper on how things are ordered.

Can you provide a zip of this minimqtt_demo.py file you're using so I can test it?

[jerryneedell]

yes but you don't need it to test -- just do the dir(string) to see if encode is there.
will post the code in a sec.

[hierophect]

yes but you don't need it to test -- just do the dir(string) to see if encode is there.
will post the code in a sec.

In that case, I'll just need a full list of whatever other includes I need to replicate your result.

[jerryneedell]

yes but you don't need it to test -- just do the dir(string) to see if encode is there.
will post the code in a sec.

In that case, I'll just need a full list of whatever other includes I need to replicate your result.

none - do a clean boot
at REPL

string = "test"
dir(string)

if encode is in the list -- it is fixed

the code needs an airlift and several libraries -- do you want it?

[hierophect]

Ah, sorry! I'm actually quite bad at python. All C over here :)

[hierophect]

Shouldn't need anything else. I'll ping you once I've got the attribute back in there and we'll do another full hardware test.

[jerryneedell]

Ah, sorry! I'm actually quite bad at python. All C over here :)

no problem! it's a simple check -- also if you have another board - any express board with full build -- you can do the same thing to compare the output -- that was what I meant by showing the grandcentral result.

[jerryneedell]

Shouldn't need anything else. I'll ping you once I've got the attribute back in there and we'll do another full hardware test.

it worked ok when I changed it in py/circuitpy_mpconfig.h

#define MICROPY_CPYTHON_COMPAT                (CIRCUITPY_FULL_BUILD)
to
#define MICROPY_CPYTHON_COMPAT                1

[hierophect]

Right, the trick is that's overriding the port level define, rather than the other way around. So I'll need to add some logic there to get around that.

[hierophect]

Sorry for the delay, slipped my todo list today. Just needed to swap over to a CFLAG and add the redefine logic to the .h file. Works for me now (raw test with string dir, I don't have MiniMQTT set up). This whole section still needs a conceptual revamp, but we'll follow up on that in #2458.

Give this a spin and hopefully we can get it in stat.

[jerryneedell]

tested on feather_stm32f405_express with minimqtt_adafruit_io_wifi demo -- works normally !!
also verified that .encode is available for strings....
Looks good

[hierophect]

@dhalbert just wanted to quickly check with you whether this mpconfig.h change is ok

[jerryneedell]

Is this awaiting further review?

[hierophect]

I was hoping either @tannewt or @dhalbert would review this small addition to circuitpy_mpconfig.h, since that's a micropython holdover, and I'm not always aware of cascade affects that can occur from changes to that kind of file.

[tannewt]

Looks good! Sorry for the delay.