Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uChip board support for Circuitpython environment #1700

Merged
merged 9 commits into from
Mar 25, 2019

Conversation

ITACAInnovation
Copy link

This is a pull request to add support for uChip into the Circuitpython environment.

We tested the attached code below and it seems to work with Circuitpython.
If there are any suggestions or changes needed, please let us know!

What is uChip in brief?
A complete USB dev board the size of a narrow 16-DIP package, featuring Atmel SAMD21 Cortex M0+ and onboard switching converters. (OTG compliant and power delivery up to 1A@5V or 3V3).
For more details refer to the ongoing campaign on kickstarter.
www.kickstarter.com/projects/1186620431/uchip-arduino-zero-compatible-in-a-narrow-dip-16-p

This is a pull request to add support for uChip into the Circuitpython environment.

We tested the uploaded code and it seems to work with Circuitpython.
If there are any suggestions or changes needed, please let us know!


What is uChip in brief?
A complete USB dev board the size of a narrow 16-DIP package, featuring Atmel SAMD21 Cortex M0+ and onboard switching converters. (OTG compliant and power delivery up to 1A@5V or 3V3).
For more details refer to the ongoing campaign on kickstarter.
www.kickstarter.com/projects/1186620431/uchip-arduino-zero-compatible-in-a-narrow-dip-16-p
@ITACAInnovation ITACAInnovation marked this pull request as ready for review March 25, 2019 13:17
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the pin definitions, and it looks OK. Could you add your board as the last board in this line in .travis.yml, so that it gets built automatically?

  - TRAVIS_BOARDS="feather_radiofruit_zigbee gemma_m0 hallowing_m0_express itsybitsy_m0_express itsybitsy_m4_express meowmeow sam32" TRAVIS_SDK=arm

We try to keep the number of boards on each line about the same, and that line only has seven.

ITACAInnovation added a commit to ITACAInnovation/circuitpython that referenced this pull request Mar 25, 2019
Updated as asked in pullrequest adafruit#1700
@dhalbert
Copy link
Collaborator

Please make the .travis.yml change in this PR by pushing another commit; I've closed #1701.

Commit change with updated board list
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After thinking about this a bit:

  1. Could you please rename the board directory from uChip to uchip (all lower case)?
  2. Change the .travis.yml line as well to match.

It's fine that uChip (with a capital C) is the MICROPY_HW_BOARD_NAME, but all the directory names should be uniformly lower case.

Thanks, sorry I didn't catch this earlier.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi - Rename the boards/uChip directory to boards/uchip. It looks like you moved just the one file to a renamed directory, but all the files under uChip to should be in uchip.

@ITACAInnovation
Copy link
Author

Moved them all, check it out, there should be no more uChip folder now.

@dhalbert
Copy link
Collaborator

ok, great, we crossed while you were doing the renames.

@ITACAInnovation
Copy link
Author

No problem, sorry for the delay.

@dhalbert
Copy link
Collaborator

The German (de_DE) build failed, almost certainly because of size. Add

CIRCUITPY_FREQUENCYIO = 0

to the end of your mpconfigboard.mk file, and it should be OK after that. See gemma_m0/mpconfigboard.mk as an example.

@ITACAInnovation
Copy link
Author

The project built correctly I think.
Thanks for the support

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new board!

You can now add your board to https://circuitpython.org. Look at https://github.com/adafruit/circuitpython-org, and see about a PR adding your board there (pictures, description, etc.)

@dhalbert dhalbert merged commit 7bac10a into adafruit:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants