shared-bindings/socket: add socket.recv_into #1682
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
socket_recv_into
method ontosocket
so that users can read from a socket without needing to allocate a new bytestring for each read_socket_recv_into
to deduplicate code betweensocket_recv_into
andsocket_recv
I wasn’t sure whether
shared-bindings/socket/__init__.c
was the right place to put the helper function_socket_recv_into
, so apologies if there is a better place to put this!Thanks for taking a look 😄