support user-configuration files#10817
Conversation
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Thanks - this seems convenient. I often end up editing an mpconfigboard.mk temporarily, but this is less intrusive.
|
I changed the filenames as you suggested. |
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Thanks. I hope you think the new names clarify things.
|
@tannewt Do you have any suggestions? If not I'll merge. |
Yes they do, thanks for the suggestions. |
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
This looks fine to me. The one suggestion I have is to document this somewhere so others can use it. Maybe somewhere in docs/?
|
What about adding a section in |
Works for me! Thanks! |
This reduces inconsitencies between esp32 and other ports. According to the discussion in adafruit#10817. Signed-off-by: Ihor Nehrutsa <Ihor.Nehrutsa@gmail.com>
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Thanks for the nice writeup!
There was a GitHub CI failure. I re-ran the failed jobs and it succeeded.
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Looks good to me too! Thanks!
3 participants
This patch adds support for user-specific makefile-includes.
Currently, there are mainly
mpconfigboard.mk(board-specific)mpconfigport.mk(port-specific)circuitpy_mpconfig.mk(globals)User-overrides are possible from the
makecommandline (except for a number of hardcoded settings), but this gets tedious. This patch allows power-users to put the changes in user-specific files with the added benefit that you can use makefile-logic to limit the changes to specific ports or boards.User configuration can be maintained out-of-tree, e.g.
will build with two different sets of user-configurations.
User configurations are optional, they are included via
-include, so a missing include file does not even generate a warning.