Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While running code in a loop, web workflow is unresponsive to Ctrl+C #8132

Closed
makermelissa opened this issue Jun 29, 2023 · 2 comments · Fixed by #8668
Closed

While running code in a loop, web workflow is unresponsive to Ctrl+C #8132

makermelissa opened this issue Jun 29, 2023 · 2 comments · Fixed by #8668
Assignees
Milestone

Comments

@makermelissa
Copy link
Collaborator

CircuitPython version

Adafruit CircuitPython 8.2.0-rc.1 on 2023-06-27; Adafruit Feather ESP32-S2 TFT with ESP32S2

Code/REPL

import time

while True:
    print("Hello World!")
    time.sleep(1)

Behavior

Using a Web Workflow serial connection, pressing Ctrl-C does not work as expected. It occasionally works, but not most of the time.

Description

I verified that this works as expected in 8.0.0-beta.6, so it broke along the way. I'm pretty sure it doesn't work in 8.1.0 either. I'm not sure when it stopped working.

Additional information

See circuitpython/web-editor#115 for additional details.

@dhalbert
Copy link
Collaborator

dhalbert commented Jul 5, 2023

Maybe should fix this in 8.2.x.

@tannewt
Copy link
Member

tannewt commented Nov 28, 2023

I think this was broken by #7836. It adds a catch all break when no new connection is available that skips the websocket_background call.

@tannewt tannewt self-assigned this Nov 28, 2023
dhalbert pushed a commit that referenced this issue Nov 28, 2023
It was skipped in many cases which breaks ctrl-cing running code.

Fixes #8132
lovrojakic pushed a commit to lovrojakic/circuitpython that referenced this issue Jan 9, 2024
It was skipped in many cases which breaks ctrl-cing running code.

Fixes adafruit#8132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants