Sending Requests Failed on second network call in CircuitPython 7.0.0

[makermelissa]

This was originally found by a user in the forums at https://forums.adafruit.com/viewtopic.php?f=19&t=184484&p=895677. I was able to reproduce the issue by following the guide at https://learn.adafruit.com/magtag-google-calendar-event-display.

Here's the stack trace

Traceback (most recent call last):
File "code.py", line 246, in <module>
File "code.py", line 84, in get_current_time
File "adafruit_portalbase/__init__.py", line 411, in get_local_time
File "adafruit_portalbase/network.py", line 231, in get_local_time
File "adafruit_portalbase/network.py", line 200, in get_strftime
File "adafruit_requests.py", line 613, in get
File "adafruit_requests.py", line 554, in request
File "adafruit_requests.py", line 423, in _get_socket
RuntimeError: Sending request failed

After making is so get_local_time was only called once, it failed on the next network call with this stack trace:

Traceback (most recent call last):
  File "code.py", line 227, in <module>
  File "adafruit_oauth2.py", line 179, in refresh_access_token
  File "adafruit_requests.py", line 617, in post
  File "adafruit_requests.py", line 554, in request
  File "adafruit_requests.py", line 423, in _get_socket
RuntimeError: Sending request failed

The first call is successful, but any subsequent calls fail. This only happens in CircuitPython 7.0.0 and not 6.3.0. I have not tried any of the alpha, beta, or release candidate versions in between.

Note: This issue may need to be moved to the CircuitPython repo

[makermelissa]

@tannewt do you have any thoughts on this?

[anecdata]

@makermelissa If you catch the error, does it fail from then on, or is it alternating every other request that fails (I see this in one application and put workaround code in to always request twice)?

[makermelissa]

I'm not sure. I haven't tested further.

[tannewt]

My brain has purged all requests context. Sorry!

[makermelissa]

@anecdata it still fails from then on.

I've narrowed it down to the failure first occurring between CircuitPython 7 Alpha 3 and 4.

[makermelissa]

Transferring to CircuitPython since the issue is dependent on the version of CircuitPython and the fix is probably also in the core.

[tbjers]

@makermelissa This issue is just an issue with the example. I have traced through the code and discovered:

1. There can only be one socket_pool per wifi.radio
2. Initializing the radio twice isn't helping
3. The fix can be done entirely in code.py using these libraries

My only minor gripe is that I have to load secrets inside my code. It would be great if there was a public accessor or a way to pass the secrets through MagTag into PortalBase and NetworkBase. That way they can be read once, and be one source of truth.

Here's how to fix this issue (verified on a MagTag running CircuitPython 7.1.0-beta.1):

Remove initialization of wifi and requests in code.py.

Move MagTag init above OAuth2 init.

Call:

magtag.network.connect()

# Initialize an OAuth2 object with GCal API scope
scopes = ["https://www.googleapis.com/auth/calendar.readonly"]
google_auth = OAuth2(
    magtag.network.requests,
    secrets["google_client_id"],
    secrets["google_client_secret"],
    scopes,
    secrets["google_access_token"],
    secrets["google_refresh_token"],
)

Then update:

def get_calendar_events #...

to use:

magtag.network.requests.get()

and everything works swimmingly!

[JannieT]

Thanks @tbjers ! That helped a lot.
For those who might want to see a full working example that runs fine on CircuitPython v7.1.0:
https://gist.github.com/JannieT/1e589b215ec05118ab78ec5d441c69e7

[bserinese]

My MagTag just arrived yesterday and I spent today walking through the Calendar tutorial. Glad I found this thread because I was hitting the same errors. I've downloaded the example above, but have a question about calendar_id.

In the original code from the tutorial, the calendar_id for my personal calendar was hardcoded into the code.py. Does the full working example mentioned above now have the calendar_id in the secret.py file?
Or, should it go here:

now = self._iso_date(self.clock.datetime)
minTime = self._url_encode(now)
url = ("https://www.googleapis.com/calendar/v3/calendars/{0}"
       "/events?maxResults={1}&timeMin={2}&orderBy=startTime"
       "&singleEvents=true").format(self.secrets['calendar_id'], event_count, minTime)

[tbjers]

My MagTag just arrived yesterday and I spent today walking through the Calendar tutorial. Glad I found this thread because I was hitting the same errors. I've downloaded the example above, but have a question about calendar_id.

In the original code from the tutorial, the calendar_id for my personal calendar was hardcoded into the code.py. Does the full working example mentioned above now have the calendar_id in the secret.py file? Or, should it go here:

now = self._iso_date(self.clock.datetime)
minTime = self._url_encode(now)
url = ("https://www.googleapis.com/calendar/v3/calendars/{0}"
       "/events?maxResults={1}&timeMin={2}&orderBy=startTime"
       "&singleEvents=true").format(self.secrets['calendar_id'], event_count, minTime)

I would definitely put the calendar_id in your secrets.py file.

[t6b]

@makermelissa This issue is just an issue with the example. I have traced through the code and discovered:

1. There can only be one socket_pool per wifi.radio
2. Initializing the radio twice isn't helping
3. The fix can be done entirely in code.py using these libraries

My only minor gripe is that I have to load secrets inside my code. It would be great if there was a public accessor or a way to pass the secrets through MagTag into PortalBase and NetworkBase. That way they can be read once, and be one source of truth.

Here's how to fix this issue (verified on a MagTag running CircuitPython 7.1.0-beta.1):

Remove initialization of wifi and requests in code.py.

Move MagTag init above OAuth2 init.

Call:

magtag.network.connect()

# Initialize an OAuth2 object with GCal API scope
scopes = ["https://www.googleapis.com/auth/calendar.readonly"]
google_auth = OAuth2(
    magtag.network.requests,
    secrets["google_client_id"],
    secrets["google_client_secret"],
    scopes,
    secrets["google_access_token"],
    secrets["google_refresh_token"],
)

Then update:

def get_calendar_events #...

to use:

magtag.network.requests.get()

and everything works swimmingly!

Thank you kindly for posting this @tbjers. I am trying to make this work, but I still have a lot to learn. I am not exactly sure how "def get_calendar_events #...." should be adjusted to use "magtag.network.requests.get(). Any advice would be very much appreciated! Thank you.

[somenice]

Hi everyone, I'm currently using
Adafruit CircuitPython 7.1.1 on 2022-01-14; Adafruit FunHouse with ESP32S2
and I appear to be encountering a similar issue as reported here.
Never an issue with the first request, 200 OK status with get time from Adafruit IO, but fails on second request.
I've made sure to only start one Session as suggested above and tried catching any of the following errors ConnectionError, OSError, and RuntimeError but get the following:

Traceback (most recent call last):
File "asyncio/core.py", line 189, in run_until_complete
File "code.py", line 311, in main
File "asyncio/funcs.py", line 83, in gather
File "asyncio/funcs.py", line 78, in gather
File "asyncio/task.py", line 157, in next
File "asyncio/core.py", line 189, in run_until_complete
File "code.py", line 178, in get_time
File "adafruit_requests.py", line 613, in get
File "adafruit_requests.py", line 554, in request
File "adafruit_requests.py", line 423, in _get_socket
RuntimeError: Sending request failed

Making this call every 60 seconds.
Of course a HUGE benefit of asyncio is that even with a runtime error other functions can continue to run.

I've struggled a bit with the abstraction of Funhouse > PyPortal > Wifi/SocketPool and Adafruit_requests.
Would love to learn the most robust way to either persist a connection or repeat connection, either way.

Any help appreciated and please let me know if you need any further information.
Thank you