busio.SPI() and bitbangio.SPI() are not drop-in replacements for each other

[tdstranger]

Most of the associated methods are identical except for three:

readinto()
busio has these args: readinto(buffer, *, start=0, end=len(buffer), write_value=0)
bitbangio only has: readinto(buf)

write() has the same problem.
busio: write(buffer, *, start=0, end=len(buffer))
bitbangio: write(buf)

Lastly, busio has frequency() but bitbangio doesn't at all.

The learn.adafruit.com documentation does allude to busio and bitbangio being replacements but doesn't mention any SPI issues, if I remember correctly.

In my instance this means that the library for sdcard use is broken for Huzzah esp8266.

Thank you,
Stranger

[tannewt]

@caternuson are they the same now?

[caternuson]

Don't think so. But am I looking in the right place?
write:
https://github.com/adafruit/circuitpython/blob/master/shared-bindings/bitbangio/SPI.c#L198
readinto:
https://github.com/adafruit/circuitpython/blob/master/shared-bindings/bitbangio/SPI.c#L223
no entry for frequency:
https://github.com/adafruit/circuitpython/blob/master/shared-bindings/bitbangio/SPI.c#L313

[tannewt]

Yup, that's the right spot!

[jepler]

This prevents bitbangio.SPI from being used with adafruit_sdcard.