Skip to content

Added ARAMCON2 Badge #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2021
Merged

Added ARAMCON2 Badge #680

merged 1 commit into from
Apr 19, 2021

Conversation

bmeisels
Copy link
Contributor

makermelissa
makermelissa requested changes Apr 19, 2021
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for submitting. I see a couple of small things. For download instructions, either just provide a blank value. The images appear to be a bit wide. We have a guide on the sizing here: https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/preparing-the-images. They should be a ratio of 13:10 for width to height.

@bmeisels bmeisels requested a review from makermelissa April 19, 2021 17:25
makermelissa
makermelissa approved these changes Apr 19, 2021
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for making the changes.

@makermelissa makermelissa merged commit 45257ed into adafruit:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmeisels @makermelissa