Skip to content

Stop supporting 6.x in the bundles #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Stop supporting 6.x in the bundles #83

merged 1 commit into from
Dec 14, 2021

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Dec 13, 2021

Libraries are being updated for 7.0.0 only which has been out since September 20th, 2021.

I've updated the FAQ with the last bundle: https://learn.adafruit.com/welcome-to-circuitpython/frequently-asked-questions

Libraries are being updated for 7.0.0 only which has been out since September 20th, 2021.

I've updated the FAQ with the last bundle: https://learn.adafruit.com/welcome-to-circuitpython/frequently-asked-questions
@tannewt tannewt requested a review from a team December 13, 2021 23:05
@dhalbert
Copy link
Contributor

If this is merged, I can finish putting asyncio in the bundle.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested locally and confirmed that it no longer builds 6.x bundle with this change.

@dhalbert
Copy link
Contributor

In the past, we have continued to build the bundle for the previous version, I believe. Was there a motivation besides timing for this?

@dhalbert
Copy link
Contributor

dhalbert commented Dec 14, 2021

OK, based on incompatible changes like adafruit/Adafruit_CircuitPython_PYOA#29, it's OK with me to go ahead with this. But I will PR some pointers for https://circuitpython.orglibraries that point to the list of last compatible bundles

@dhalbert
Copy link
Contributor

I deleted the 20211214 6.x bundle artifact from https://github.com/adafruit/Adafruit_CircuitPython_Bundle/releases/tag/20211214, since it included the incompatible adafruit/Adafruit_CircuitPython_PYOA#29 library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants