Fix 'Blinka library required' false-positives #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit the `LIBRARY_DOESNT_NEED_BLINKA` string was being treated as a list so non of the repos were matching the libraries which didn't require blinka. This commit replaces that variable with a list and adds in the additional libraries which do not require blinka.
sommersoft
approved these changes
May 6, 2019
|
The conversation on this never really advanced (at least that I was a part of). Thanks @demophoon for getting this in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit the
LIBRARY_DOESNT_NEED_BLINKAstring was beingtreated as a list so non of the repos were matching the libraries which
didn't require blinka.
This commit replaces that variable with a list and adds in the
additional libraries which do not require blinka.
Fixes #70