Fix warning about implicitly declared assignment operator #316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this fixes a compiler warning when using the assignment operator on a
DateTimeobject. The auto-generatedDateTime& operator=(const DateTime&)is deprecated due to presence of a user provided copy constructor.(here as error, because I am compiling with
-Werror)This PR solves the issue by removing the user-provided copy constructor, therefore using auto-generated copy constructor (which is identical anyway). In this case, there is no problem with also auto-generating the assignment operator.
I can change the PR to instead add a user-defined assignment operator if you prefer that approach.
Btw, thanks for the awesome library and all of the other modules!
Best, Thomas