-
Notifications
You must be signed in to change notification settings - Fork 120
SAMD51 I2C slave support for Wire library and SAMD51 viariants. #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
thank you this is great! i think trellis is the tough one because its a multi-use port however i think lets keep it for Serial use ... that way it can be used with MIDI which our demos show off. rather than I2C sound OK? |
|
looks good to me - let me know when the PR is ready for review / merge |
|
Keep kicking ass, you are an inspiration. |
|
oh one more request, is there an example you used in Wire library to test? if it isnt already there please add the test sketch! |
|
Tested with existing examples connected to an Uno running the corresponding master/slave example:
Additionally tested |
|
In addition to the above, I was only able to extensively test on an ItsyBitsy M4 and the Trellis M4 when Serial1 was disabled. Definitely worth testing on other hardware. |
|
tested a feather m4 successfully - you're a hero @JordanMajd :) |
|
@JordanMajd hi please take a look at https://forums.adafruit.com/viewtopic.php?f=62&t=159769 if you have any suggestions for this person! |
|
rolls d20 Yep, I'll look into it tonight. |
|
:D thank u! |
Fixes #45 by adding handlers for all for SAMD51 SERCOM I2C interrupts to
wire.cppand defining them in the appropriatevariant.h.This is opened as a draft, because the M4 Trellis has a conflict as it already defined handlers for SERCOM4 for use with UART
Serial1in itsvariants.cpp. I'm looking for advice on how to best resolve this.