Skip to content

Conversation

@hathach
Copy link
Member

@hathach hathach commented Jan 31, 2019

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The code changes all look good. I built and loaded on a Feather 52840 and a PCA10056. Uploaded using the Makefile targets and J-Link. Also reloaded SD. Both boards worked fine with the new bootloader. I was able to load CircuitPython, and did a BLE test and it's working.

I did not test the OTA update.

@hathach
Copy link
Member Author

hathach commented Jan 31, 2019

thanks @dhalbert for testing this out. OTA should work as before, this fixes an issue with latest central such as iPhone X which is capable of 2M Phy and requesting nrf52840 to negotiate.

@hathach hathach merged commit 6338794 into master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants