nRF52833 updates to UF2/memory map for nRF52833 boards #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hathach
reviewed
Dec 20, 2021
Comment on lines
11
to
12
| 204, 0x80000, // FLASH_BYTES = 0x100000/2=0x80000 | ||
| 205, 0x20000, // RAM_BYTES = 0x40000/2=0x20000 |
Member
There was a problem hiding this comment.
the comment does not need to have the /2= just simply state the value for 833. Please also correct the comment column alignment as well.
hathach
reviewed
Dec 20, 2021
src/usb/uf2/uf2cfg.h
Outdated
Comment on lines
25
to
29
| #if defined(NRF52833_XXAA) | ||
| #define USER_FLASH_END 0x2D000 | ||
| #else | ||
| #define USER_FLASH_END 0xAD000 | ||
| #endif |
Member
There was a problem hiding this comment.
why would you change the computation ?
Contributor
Author
There was a problem hiding this comment.
Honestly - I am just trying to get the changes that other people got stuck in with other things. I'll revert this one and clean up the other comment.
hathach
approved these changes
Dec 21, 2021
Member
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
look good, thank you for your PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making these changes from the comments here
Memory size was indicated incorrectly for the bootloaderconfig section.
Also bringing the minor update that @braingram added to the UF2 include file in PR #198 .
As such, this should also close PR #198