Skip to content

Updates for espressif soc #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Updates for espressif soc #41

merged 1 commit into from
Dec 17, 2021

Conversation

microdev1
Copy link
Contributor

I haven't actually tested the library on esp32c3 but it should probably work.

@ladyada
Copy link
Member

ladyada commented Sep 22, 2021

hi, we'd definitely need it tested before merging since folks will ask for support!

@microdev1
Copy link
Contributor Author

Force-pushed to fix formatting. I don't have a HUB75-style matrix to test this.

@microdev1
Copy link
Contributor Author

Can we get this in without a test as that way more people can get a chance to test this and it will also allow me to include the rgbmatrix module for esp32c3 in CircuitPython, people can always open an issue if it doesn't work.

@ladyada
Copy link
Member

ladyada commented Sep 23, 2021

oof - we really prefer not to, its confusing to merge in untested code. @UnexpectedMaker do you want to test the PR?

@UnexpectedMaker
Copy link

oof - we really prefer not to, its confusing to merge in untested code. @UnexpectedMaker do you want to test the PR?

Sure, I’ll try to find some time to test this over the weekend.

@microdev1 microdev1 changed the title Allow building for esp32c3 Updates for espressif soc Nov 24, 2021
@microdev1
Copy link
Contributor Author

Now includes:

  • support esp-idf v4.4
  • add esp32c3 and esp32s3 support

- support esp-idf v4.4
- add esp32c3 and esp32s3 support
Copy link
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on esp32-s2 (metro) only, and it works as before. I didn't test s3/c3.

@jepler jepler merged commit d0a07e1 into adafruit:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants