Skip to content

Conversation

@lesamouraipourpre
Copy link
Contributor

Remove max_size usage with displayio.Group
Remove max_glyphs usage with Display_Text Label
Update OnDiskBitmap usage with filename string for CP7

Ref: #1603

Learn Guide: https://learn.adafruit.com/no-touch-hand-wash-timer-for-cpx-and-clue
Changes Needed:
Page: https://learn.adafruit.com/no-touch-hand-wash-timer-for-cpx-and-clue/clue-hand-wash-timer
Sections:

  • Display and Images: Update the OnDiskBitmap code

Remove max_glyphs usage with Display_Text Label
Update OnDiskBitmap usage with filename string for CP7
Copy link
Collaborator

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. Tested successfully with CLUE CircuitPython 6.3.0 and 7.0.0 alpha3

The guide page linked uses github code embed so when this gets merged it will get updated automatically.

@FoamyGuy
Copy link
Collaborator

I see there is a section that you mentioned on the learn guide that is not a github embed.

I think we can leave it alone though, it's got the updated code that works for both new and older versions already. The only thing missing is the comment. But I think that is okay in this case since this section is explaining the code at a higher level. I think it's okay to omit the comment to keep those snippets more concise.

@FoamyGuy FoamyGuy merged commit a3c26f2 into adafruit:main Jul 25, 2021
@lesamouraipourpre lesamouraipourpre deleted the hand-wash-timer branch July 28, 2021 16:16
@TheKitty
Copy link
Collaborator

Guide changes made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants