Add segment name definitions for alphanumeric displays #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
requested changes
Nov 12, 2023
Contributor
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
I didn't know where these segment names came from, in the .h file. It was only when I read the .ino example that I saw the link to the diagram. Could you add a comment to the .h file too?
... For segment names,
// see https://learn.adafruit.com/14-segment-alpha-numeric-led-featherwing/usage
Contributor
|
If you can do a diagram in ASCII in a comment, that would be even better. |
Author
|
Good idea! Done. |
dhalbert
approved these changes
Nov 12, 2023
Contributor
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
This looks good to me, and doesn't change the actual running code anyway, so it's an easy safe change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added segment name defines to make it easier for the user to use the alphanumeric display. I also added a simple animation that shows how to use the defines.
It makes it possible to write code like this -
alpha4.writeDigitRaw(0, ALPHANUM_SEG_C);, which is way more readanle thanalpha4.writeDigitRaw(0, 0c0004);.