Skip to content

CPython compatibility fix #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 3, 2022
Merged

CPython compatibility fix #31

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
30c0988
Fixed CPython compatibility
shulltronics Sep 28, 2022
b197cd6
Added author info and ran through black
shulltronics Sep 28, 2022
0161017
Actually added author info
shulltronics Sep 28, 2022
cf9a11a
Fixed test errors by implementing __getitem__ method for Vec2D
shulltronics Sep 28, 2022
8c32679
Removed author info
shulltronics Oct 1, 2022
017591b
try has-a tuple instead of is-a tuple for Vec2D
FoamyGuy Oct 1, 2022
5acb2d0
only import board if we are going to try to use builtin display
FoamyGuy Oct 1, 2022
c146d6b
allow import outside top for board
FoamyGuy Oct 1, 2022
87ee248
remove unused super init
FoamyGuy Oct 1, 2022
12e4ec2
Merge remote-tracking branch 'shulltronics/cpython-compatibility' int…
FoamyGuy Oct 1, 2022
47f94f2
Merge pull request #1 from FoamyGuy/foamyguy_cpython_compat
shulltronics Oct 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions adafruit_turtle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
import gc
import math
import time
import board
import displayio

__version__ = "0.0.0+auto.0"
Expand Down Expand Up @@ -80,7 +79,7 @@ def __init__(self):
pass


class Vec2D(tuple):
class Vec2D:
"""A 2 dimensional vector class, used as a helper class
for implementing turtle graphics.
May be useful for turtle graphics programs also.
Expand All @@ -95,7 +94,10 @@ class Vec2D(tuple):
# |a| absolute value of a
# a.rotate(angle) rotation
def __init__(self, x, y):
super().__init__((x, y))
self.values = (x, y)

def __getitem__(self, index):
return self.values[index]

def __add__(self, other):
return Vec2D(self[0] + other[0], self[1] + other[1])
Expand Down Expand Up @@ -147,6 +149,9 @@ def __init__(self, display=None, scale=1):
self._display = display
else:
try:
# pylint: disable=import-outside-toplevel
import board

self._display = board.DISPLAY
except AttributeError as err:
raise RuntimeError(
Expand Down Expand Up @@ -397,6 +402,7 @@ def goto(self, x1, y1=None):

setpos = goto
setposition = goto

# pylint:enable=too-many-branches,too-many-statements

def setx(self, x):
Expand Down