-
Notifications
You must be signed in to change notification settings - Fork 37
Closed
Description
Not sure why GRBW was chosen as default:
| self._pixel_order = GRBW if pixel_order is None else pixel_order |
This PR:
#102
changed the behavior in a way that seems to be breaking things elsewhere.
adafruit/Adafruit_CircuitPython_NeoTrellis#18
adafruit/Adafruit_CircuitPython_NeoKey#7
There's a simple fix for those - just explicitly specify pixel order, ex:
adafruit/Adafruit_CircuitPython_NeoTrellis#19
But maybe RGB or GRB is a better default?
Also, could potentially change to using strings instead of tuples to match the main NeoPixel library behavior.
https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel/blob/839b55ce88eaf04a60b3d147b13dbaa7d7404c14/neopixel.py#L115-L119
Metadata
Metadata
Assignees
Labels
No labels