Added reference to attributes from parent module in CPython #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @aziascreations - this patch is failing on our build CI, specifically on the PyLint step: https://github.com/adafruit/Adafruit_CircuitPython_hashlib/pull/14/checks?check_run_id=2399955531 Please read thru https://learn.adafruit.com/improve-your-code-with-pylint and make the required changes. If you have any questions about this process, please let me know. |
|
@aziascreations Hello, would you able to check the links that brentru gave you, let me know if you need any help, we could help you with the PR. Thanks |
|
I re-created the error reported and confirmed the fix. I've added a commit to import the algos instead of declaring variables which avoids the @brentru what do you think of latest version in this PR? |
FoamyGuy
approved these changes
Jan 16, 2022
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 17, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 0.5.5 from 0.5.4: > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#13 from dhalbert/forgot-await-message Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 8.1.4 from 8.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#149 from tekktrik/doc/add-missing-files Updating https://github.com/adafruit/Adafruit_CircuitPython_hashlib to 1.4.1 from 1.4.0: > Merge pull request adafruit/Adafruit_CircuitPython_hashlib#14 from aziascreations/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just a simple patch to add references to the implementation's hashlib attributes if it exists.
This omission caused the "adafruit_rsa" library to return the following error on CPython, but not on CircuitPython:
More checks can be added if needed in order to reference the library's implementation of the hashing algorithms if they are not present in the implementation's version of hashlib.