Skip to content

update dual mouse example to support 8 byte data packets #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025

Conversation

FoamyGuy
Copy link
Contributor

@FoamyGuy FoamyGuy commented Apr 3, 2025

No description provided.

@FoamyGuy
Copy link
Contributor Author

FoamyGuy commented Apr 3, 2025

Tested successfully with Metro RP2350 with a build from the branch for adafruit/circuitpython#10220

@FoamyGuy FoamyGuy requested a review from a team April 3, 2025 20:43
TheKitty
TheKitty previously approved these changes Apr 3, 2025
@FoamyGuy FoamyGuy dismissed TheKitty’s stale review April 3, 2025 20:52

Sorry, I refactored this a bit further in a new commit after the view.

@FoamyGuy
Copy link
Contributor Author

FoamyGuy commented Apr 3, 2025

In the latest commit I changed get_mouse_deltas() to accept a buffer and a read_count instead of mouse_index that points into a local list variable within this example code.

That change makes the function more usable generally outside of this example. I'm hopeful that this function or something like it can eventually live inside of the library instead of an example so that user code that wants to use mice can call an function like this that abstracts away the differences between mice.

Sorry to change it after I requested review the first time and your review @TheKitty. If you get a moment it can use another review with the latest version.

@TheKitty
Copy link

TheKitty commented Apr 3, 2025

No worries

@FoamyGuy FoamyGuy merged commit ca51f2d into adafruit:main Apr 3, 2025
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants