Skip to content

Add current control & inverted option #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2024
Merged

Add current control & inverted option #4

merged 2 commits into from
Oct 21, 2024

Conversation

jepler
Copy link
Contributor

@jepler jepler commented Oct 21, 2024

Closes: #3
Closes: #2

FoamyGuy
FoamyGuy approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I don't have the LEDs to test with. Thanks for the constructor docstrings too!

@jepler jepler merged commit 545e946 into main Oct 21, 2024
2 checks passed
@jepler jepler deleted the current-control branch October 21, 2024 21:21
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 24, 2024
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@d9386e4)
56ac7c3 
Updating https://github.com/adafruit/Adafruit_CircuitPython_TM1814 to 1.0.0 from 1.0.0-pre.0:
  > Default current should be minimum, not maximum
  > Merge pull request adafruit/Adafruit_CircuitPython_TM1814#4 from adafruit/current-control
  > Merge pull request adafruit/Adafruit_CircuitPython_TM1814#1 from adafruit/uppercase

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 7.2.0 from 7.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#172 from CytronTechnologies/add_baudrate_option

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

don't use chip current-control register to implement brightness property Add "inverted" option
2 participants
@jepler @FoamyGuy