Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Missing Type Annotations #14

Merged
merged 11 commits into from
Sep 2, 2022
Merged

Add Missing Type Annotations #14

merged 11 commits into from
Sep 2, 2022

Conversation

tcfranks
Copy link
Contributor

resolves #8
submitted for review/comment

@tekktrik tekktrik requested a review from a team August 26, 2022 22:11
FoamyGuy
FoamyGuy requested changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on another one of these @tcfranks.

Found one argument that should be different I think. But rest of this is looking good to me.

adafruit_scd4x.py Outdated Show resolved Hide resolved
tekktrik
tekktrik requested changes Sep 1, 2022
View reviewed changes
adafruit_scd4x.py Outdated Show resolved Hide resolved
@tcfranks
Copy link
Contributor Author

tcfranks commented Sep 1, 2022

resubmitted successfully for review of changes

tekktrik
tekktrik approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And thanks @FoamyGuy for the initial review!

@tekktrik tekktrik merged commit a9ae07d into adafruit:main Sep 2, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 2, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@7ce195f)
b6aa638 
Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS2MDL to 2.1.17 from 2.1.16:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS2MDL#15 from BrianPugh/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD4X to 1.3.7 from 1.3.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_SCD4X#14 from tcfranks/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy requested changes

@tekktrik tekktrik tekktrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
3 participants
@tcfranks @FoamyGuy @tekktrik