-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Missing Type Annotations #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on another one of these @tcfranks.
Found one argument that should be different I think. But rest of this is looking good to me.
resubmitted successfully for review of changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! And thanks @FoamyGuy for the initial review!
Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS2MDL to 2.1.17 from 2.1.16: > Merge pull request adafruit/Adafruit_CircuitPython_LIS2MDL#15 from BrianPugh/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD4X to 1.3.7 from 1.3.6: > Merge pull request adafruit/Adafruit_CircuitPython_SCD4X#14 from tcfranks/main
resolves #8
submitted for review/comment