Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert .show() to .root_group = for CircuitPython 9 #48

Closed
dhalbert opened this issue Nov 2, 2023 · 2 comments · Fixed by #49
Closed

Convert .show() to .root_group = for CircuitPython 9 #48

dhalbert opened this issue Nov 2, 2023 · 2 comments · Fixed by #49

Comments

@dhalbert
Copy link
Contributor

dhalbert commented Nov 2, 2023

No description provided.

@prcutler
Copy link
Contributor

prcutler commented Nov 2, 2023

The file macropad_grid_layout.py (https://github.com/adafruit/Adafruit_CircuitPython_MacroPad/blob/main/examples/macropad_grid_layout.py) has this code in it:

macropad.display.show(main_group) on line 17

I assume this should not be updated with the root_group fix for CP9 as that functionality is from the MacroPad module?

@FoamyGuy
Copy link
Contributor

FoamyGuy commented Nov 2, 2023

@prcutler it should be changed. That usage is on the macropad class which isn't what changed so your instinct does make sense. But the macropad actually has a normal display object on it that is being accessed so it will use the new API as well. Here is the code inside of Macropad class where it sets up the display that is being used:

# Define display:
if not isinstance(board.DISPLAY, type(None)):
self.display = board.DISPLAY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants