Skip to content

Give the opportunity to set the polarity to 1 and not 0. #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

emmanuelthome
Copy link
Contributor

Given that the MAX31865 can deal with both, it seems reasonable to expose this in the interface.

Given that the MAX31865 can deal with both, it seems reasonable to expose this in the interface.
@jposada202020
Copy link
Contributor

@emmanuelthome want to try to test this changes, not very familiar with the hardware, so, if we need to test this change, setting the polarity property to 1, we could invert the cable connections?
Thanks

@emmanuelthome
Copy link
Contributor Author

Yes, connect to a clock that idles high.

I presume that you can bit-bang this using gpio pins, too. this would require the spidevice to be handled directly from python so that you can use any signal pins you like, as opposed to using the microcontroller hardware spi. Not sure if there's a testing mechanism to do that.

@jposada202020
Copy link
Contributor

Ok, understood, according to this it seems that I need to do some reading also, will do over the weekend, thanks for your contribution :) keep you posted with my results or questions.

@jposada202020
Copy link
Contributor

@emmanuelthome my bad, so while reading the datasheet I discovered that inverted the last two numbers, So I have the MAX31856. However this will be solved next week, and I will have (sure, sure) the MAX31865. So I could review. sorry :)

@evaherrada evaherrada changed the base branch from master to main June 7, 2021 15:51
@jposada202020
Copy link
Contributor

sooooo I have good news and bad news, good news is I received the breakout, bad news is that either I fried it or I solder it wrong.
I kept getting

Temperature: -115.990C
Temperature: 463.521C
Temperature: -115.990C

all the time
So I do not have the means to test this, so hopefully other person could test this.. Thanks

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested successfully with Feather RP2040 and simpletest script, confirmed new polarity argument that gets passed to SPIDevice constructor.

@FoamyGuy FoamyGuy merged commit 74a97d5 into adafruit:main Jan 17, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 18, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31865 to 2.2.11 from 2.2.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31865#33 from emmanuelthome/expose_polarity_and_phase
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31865#32 from emmanuelthome/enable_auto_convert
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.5.4 from 1.5.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#54 from tekktrik/hotfix/fix-attribute-error
  > update rtd py version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants