Fix adafruit_irremote.GenericDecode's decode() method to return decoded result #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the decode_bits() method in the object wrapper to return the IRMessage returned by the decode_bits() function. Otherwise decoder.decode_bits() is returning None.
…. Brings patch into compliance with published API.
|
Closing this pull request because it was not quite right. The next pull request will bring the code into compliance with the readthedocs API. |
|
Fix the decode_bits() method in the object wrapper to return the IRMessage returned by the decode_bits() function. Otherwise decoder.decode_bits() was returning None. Fixes #47, and brings the decode_bits() method into compliance with the published API in readdocs. |
dhalbert
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
Thanks for this fix!! I was just debugging this as https://github.com/adafruit/circuitpython/issues/5311, and you fixed it. Tested.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 18, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_AHTx0 to 1.0.10 from 1.0.9: > Fixed readthedocs build > Merge pull request adafruit/Adafruit_CircuitPython_AHTx0#11 from tammymakesthings/issue9-add-type-annotations > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_AMG88xx to 1.2.11 from 1.2.10: > Fixed readthedocs build > Merge pull request adafruit/Adafruit_CircuitPython_AMG88xx#35 from tammymakesthings/issue32-add-type-annotations > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_AS7341 to 1.2.5 from 1.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#27 from tekktrik/doc/reveal-gain-class > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#25 from tammymakesthings/update-requirements-for-typing Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X_RVC to 1.0.8 from 1.0.7: > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x_RVC#5 from tekktrik/doc/add-typing > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 4.1.3 from 4.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#51 from lstein/decode-bug-fix > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Radio to 0.5.1 from 0.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Radio#22 from infamy/patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the decode_bits() method in the object wrapper to return the IRMessage returned by the decode_bits() function. Otherwise decoder.decode_bits() was returning None.
Fixes #47
Fixes #52
Fixes #48