Are the "set_calibration" methods correct?

[sprocter]

Summary

I am using the INA228 on a low-amperage system, so I was calling set_calibration_16V_400mA() in my project's initialization. However, the values produced seemed to be incorrect -- they were much lower than what I expected, and were very different from what was produced by the INA260.

I found that a recent change (5e099d3) changed first parameter of the call in set_shunt(...) from 0.1 to 0.015 in the INA228 class's initialization. Similar changes weren't made to the set_calibration methods, though, which also call set_shunt. When I called set_shunt directly and mirrored the change from 5e099d3 -- i.e., I called set_shunt(0.015, 0.4) -- I got measurements output in line with my estimates / the output of the INA260.

Expected Output

Amperage readings in line with estimates derived from datasheets.

Actual Output

Very low amperage readings.

[BlitzCityDIY]

i'm going to be looking at this library tomorrow for the new ina237 breakout so will test and push a fix soon