Add fast reading function and refactor read_channel methods for HX711 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
approved these changes
Oct 27, 2025
Contributor
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for working on this!
Closed
adafruit-adabot
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 28, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_HX711 to 1.1.0 from 1.0.8: > Merge pull request adafruit/Adafruit_CircuitPython_HX711#9 from supcik/main Updating https://github.com/adafruit/Adafruit_CircuitPython_FruitJam to 1.6.4 from 1.6.3: > Merge pull request adafruit/Adafruit_CircuitPython_FruitJam#26 from FoamyGuy/add_missing_docstrings
Contributor
Author
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue #7.
I made a separated function
read_fastfor the bit banging reading of the AD. This improved the performance by caching the object reference and opens up possibilities for other implementations.The delays are enforced with the
microcontroller.delay_usfunction.I had to disable the interrupts during the read, because according to the datasheet, the clock is not allowed to stay up for more than 50µs during the operation :
With interrupts on, I was not able to guarantee the correct timing.
I tested on a ESP32 and it never failed.
Note that some other lines have been reformated according to the style guide defined in
ruff.toml(line-length = 100)